From de5a7e1ee9433950b32511bacdb493d68fadaf82 Mon Sep 17 00:00:00 2001 From: Christophe Coevoet Date: Mon, 19 Sep 2022 15:43:51 +0200 Subject: [PATCH 1/3] Fix the type linting command to actually check the relevant types Disabling the checks for lib files will hide typescript errors in the stylelint type definitions, as those are loaded as a lib type when type-checking type-test.ts --- tsconfig.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tsconfig.json b/tsconfig.json index 5c22e4b92c..9ceab8841c 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -15,7 +15,7 @@ "noUncheckedIndexedAccess": true, "esModuleInterop": true, "resolveJsonModule": true, - "skipLibCheck": true, + "skipLibCheck": false, "typeRoots": ["./types", "./node_modules/@types"] }, "include": ["lib", "types", "package.json"], From 1ec2d8eb88faf94cb459edccee6acbaf311dcd78 Mon Sep 17 00:00:00 2001 From: Christophe Coevoet Date: Mon, 19 Sep 2022 15:48:18 +0200 Subject: [PATCH 2/3] Fix type declarations for custom message arguments --- types/stylelint/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/stylelint/index.d.ts b/types/stylelint/index.d.ts index f70fd7afa8..2afb65d3ff 100644 --- a/types/stylelint/index.d.ts +++ b/types/stylelint/index.d.ts @@ -353,7 +353,7 @@ declare module 'stylelint' { ruleName: string; result: PostcssResult; message: RuleMessage; - messageArgs?: Parameters | undefined; + messageArgs?: Parameters | undefined; node: PostCSS.Node; /** * The inclusive start index of the problem, relative to the node's From c192820eace7d73a99f746efc8a1ea551c2f9b06 Mon Sep 17 00:00:00 2001 From: Christophe Coevoet Date: Mon, 19 Sep 2022 16:00:00 +0200 Subject: [PATCH 3/3] Add changelog entry --- .changeset/eleven-monkeys-return.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/eleven-monkeys-return.md diff --git a/.changeset/eleven-monkeys-return.md b/.changeset/eleven-monkeys-return.md new file mode 100644 index 0000000000..f762151a99 --- /dev/null +++ b/.changeset/eleven-monkeys-return.md @@ -0,0 +1,5 @@ +--- +"stylelint": patch +--- + +Fixed: type declarations for custom message arguments