Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives for interpolation and shorthand in font-family-name-quotes #6335

Merged
merged 4 commits into from Sep 11, 2022

Conversation

kimulaco
Copy link
Member

Which issue, if any, is this issue related to?

Closes #4154

Is there anything in the PR that needs further explanation?

I updated to change the timing of executing isStandardSyntaxValue to ignore problematic cases.

However, if customSyntax is not set to 'postcss-scss', CssSyntaxError is raised.
I think this error is correct because this bug is SCSS syntax.

@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2022

🦋 Changeset detected

Latest commit: f788767

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kimulaco Thanks, LGTM. 👍🏼

@jeddy3 jeddy3 changed the title Fix SCSS syntax check for font-family-name-quotes Fix false positives for interpolation and shorthand in font-family-name-quotes Sep 11, 2022
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kimulaco Thanks for the pull request. LGTM.

@jeddy3 jeddy3 merged commit d8f2d9c into stylelint:main Sep 11, 2022
@kimulaco kimulaco deleted the fix/issue-4154 branch September 21, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix false positives for interpolation and shorthand in font-family-name-quotes
3 participants