Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect location for matching violating times in time-min-milliseconds #6319

Merged
merged 10 commits into from Sep 9, 2022

Conversation

kawaguchi1102
Copy link
Contributor

Which issue, if any, is this issue related to?

Closes #4751

Is there anything in the PR that needs further explanation?

Fixed the following additions

  • Fix Test case end positions

@changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2022

🦋 Changeset detected

Latest commit: 7a8d665

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kawaguchi1102 Thanks for creating the PR. The change looks almost good to me.

I've left some refactoring suggestions, so please consider addressing them.

lib/rules/time-min-milliseconds/index.js Outdated Show resolved Hide resolved
lib/rules/time-min-milliseconds/index.js Outdated Show resolved Hide resolved
lib/rules/time-min-milliseconds/index.js Outdated Show resolved Hide resolved
@kawaguchi1102
Copy link
Contributor Author

The refactor has been completed.
I hope I am not mistaken in this refactor.

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kawaguchi1102 Thank you, the code is now more straightforward and readable! Almost no problem.
I've left easy refactoring suggestions, so please check them.

lib/rules/time-min-milliseconds/index.js Outdated Show resolved Hide resolved
lib/rules/time-min-milliseconds/index.js Outdated Show resolved Hide resolved
lib/rules/time-min-milliseconds/index.js Outdated Show resolved Hide resolved
@kawaguchi1102
Copy link
Contributor Author

@ybiquitous Thank you for reviewing every detail!
Now we have a cleaner code!

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM 👍🏼

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jeddy3 jeddy3 merged commit 3d48df4 into stylelint:main Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix incorrect location for matching violating times in time-min-milliseconds
3 participants