New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect location for matching violating times in time-min-milliseconds
#6319
Conversation
🦋 Changeset detectedLatest commit: 7a8d665 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kawaguchi1102 Thanks for creating the PR. The change looks almost good to me.
I've left some refactoring suggestions, so please consider addressing them.
f70f166
to
c71fb9f
Compare
The refactor has been completed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kawaguchi1102 Thank you, the code is now more straightforward and readable! Almost no problem.
I've left easy refactoring suggestions, so please check them.
@ybiquitous Thank you for reviewing every detail! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. LGTM 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Closes #4751
Fixed the following additions