New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix false positives for container queries in *-no-unknown
#6318
Fix false positives for container queries in *-no-unknown
#6318
Conversation
🦋 Changeset detectedLatest commit: af1e0b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
You gotta add cqw, cqh, cqi, cqb, cqmin, and cqmax to stylelint/lib/reference/units.js Line 6 in 12f1141
I consider the second note irrelevant. |
*-no-unknown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fpetrakov Thanks for creating the PR!
Almost good, but I've suggested a few refactorings. Please consider addressing them.
b27d5e3
to
2ed33a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM 👍🏼
Closes #6304.
No, it's self-explanatory.