Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives for container queries in *-no-unknown #6318

Merged

Conversation

fpetrakov
Copy link
Contributor

Which issue, if any, is this issue related to?

Closes #6304.

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

@changeset-bot
Copy link

changeset-bot bot commented Sep 2, 2022

🦋 Changeset detected

Latest commit: af1e0b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@fpetrakov fpetrakov changed the title At rule no unknown container queries Aware @container with at-rule-no-unknown Sep 2, 2022
@Mouvedia
Copy link
Contributor

Mouvedia commented Sep 2, 2022

You gotta add cqw, cqh, cqi, cqb, cqmin, and cqmax to

// Relative length units

I consider the second note irrelevant.

@jeddy3 jeddy3 changed the title Aware @container with at-rule-no-unknown Fix false positives for container queries in *-no-unknown Sep 2, 2022
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fpetrakov Thanks for creating the PR!

Almost good, but I've suggested a few refactorings. Please consider addressing them.

lib/reference/atKeywords.js Outdated Show resolved Hide resolved
lib/reference/units.js Outdated Show resolved Hide resolved
@fpetrakov fpetrakov force-pushed the at-rule-no-unknown-container-queries branch from b27d5e3 to 2ed33a8 Compare September 3, 2022 10:21
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM 👍🏼

@ybiquitous ybiquitous merged commit 2b17f21 into stylelint:main Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix false positives for container queries in *-no-unknown
4 participants