New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autofix to declaration-block-no-duplicate-properties #6296
Add autofix to declaration-block-no-duplicate-properties #6296
Conversation
🦋 Changeset detectedLatest commit: fd25dfb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fpetrakov Thanks for creating the PR! 👍🏼
Can you please address the following suggestions?
- add
fixable: true
to the metadata like this:
fixable: true, - add a description to the rule readme like this:
The [`fix` option](../../../docs/user-guide/usage/options.md#fix) can automatically fix all of the problems reported by this rule.
lib/rules/declaration-block-no-duplicate-properties/__tests__/index.js
Outdated
Show resolved
Hide resolved
332d965
to
f4ef93b
Compare
Hmm, now all tests are failing, let's see... |
This comment was marked as resolved.
This comment was marked as resolved.
lib/rules/declaration-block-no-duplicate-properties/__tests__/index.js
Outdated
Show resolved
Hide resolved
lib/rules/declaration-block-no-duplicate-properties/__tests__/index.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fpetrakov Thank you! LGTM 👍🏼
@ybiquitous should we merge it or call jeddy3 to review changes? |
Let's wait for a few more additional reviews. I may have missed something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fpetrakov LGTM, thank you.
@ybiquitous Thanks for the initial review and suggestions!
should we merge it or call jeddy3 to review changes?
We usually use our judgement to determine how many reviews a pull request needs. Although, it's usually one for simple things and, as @ybiquitous suggested, two when adding new features like options or rules.
If we going to merge, don't forget to add the changesets, because it's already a new iteration. |
Closes #6119.
No, it's self-explanatory.