Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autofix to declaration-block-no-duplicate-properties #6296

Conversation

fpetrakov
Copy link
Contributor

Which issue, if any, is this issue related to?

Closes #6119.

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2022

🦋 Changeset detected

Latest commit: fd25dfb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fpetrakov Thanks for creating the PR! 👍🏼

Can you please address the following suggestions?

@fpetrakov fpetrakov force-pushed the add-autofix-to-declaration-block-no-duplicate-properties branch from 332d965 to f4ef93b Compare August 23, 2022 07:25
@fpetrakov
Copy link
Contributor Author

Hmm, now all tests are failing, let's see...

@ybiquitous

This comment was marked as resolved.

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fpetrakov Thank you! LGTM 👍🏼

@fpetrakov
Copy link
Contributor Author

@ybiquitous should we merge it or call jeddy3 to review changes?

@ybiquitous
Copy link
Member

Let's wait for a few more additional reviews. I may have missed something.

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fpetrakov LGTM, thank you.

@ybiquitous Thanks for the initial review and suggestions!

should we merge it or call jeddy3 to review changes?

We usually use our judgement to determine how many reviews a pull request needs. Although, it's usually one for simple things and, as @ybiquitous suggested, two when adding new features like options or rules.

@JounQin
Copy link
Member

JounQin commented Aug 23, 2022

If we going to merge, don't forget to add the changesets, because it's already a new iteration.

@ybiquitous
Copy link
Member

@JounQin Thanks for the reminder. I've pushed fd25dfb. No problems?

@JounQin
Copy link
Member

JounQin commented Aug 24, 2022

@JounQin Thanks for the reminder. I've pushed fd25dfb. No problems?

No problem.

@ybiquitous ybiquitous merged commit 8e6a576 into stylelint:main Aug 24, 2022
This was referenced Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add autofix to declaration-block-no-duplicate-properties
4 participants