Fix plugins.md
document and createPlugin
type definition
#6264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6245
This PR mainly fixes the incorrect examples on the plugin document. Also, this improves the type definition of the
stylelint.createPlugin()
API, although it may be called refactorings.The incorrect part on the doc is here: ⬇️
stylelint/docs/developer-guide/plugins.md
Lines 53 to 55 in e424be5
Because
stylelint.createPlugin()
returns an object{ ruleName: string, rule: Function }
,stylelint/lib/createPlugin.js
Lines 10 to 15 in 4772851
the following code using
module.exports
produces an incorrect object{ ruleName: string, rule: Function, messages: Object, meta: Object }
.To be correct, the
rule
function should have theruleName
,messages
, andmeta
properties as below. The current example on the doc is confusing.For example, the
stylelint-scss
plugin sets the properties correctly.