Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selector-pseudo-class-allowed-list end positions and message #6262

Merged
merged 1 commit into from Aug 14, 2022
Merged

Fix selector-pseudo-class-allowed-list end positions and message #6262

merged 1 commit into from Aug 14, 2022

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Aug 13, 2022 •
edited

Which issue, if any, is this issue related to?

Part of #5694

Is there anything in the PR that needs further explanation?

This PR also fixes the message in addition to end positions; I think including the : character for pseudo-classes is more helpful. E.g.

-Unexpected pseudo-class "focus"
+Unexpected pseudo-class ":focus"

@ybiquitous ybiquitous marked this pull request as ready for review August 13, 2022 09:34
@ybiquitous ybiquitous marked this pull request as draft August 13, 2022 09:35
@ybiquitous ybiquitous marked this pull request as ready for review August 13, 2022 09:35
@ybiquitous ybiquitous mentioned this pull request Aug 13, 2022
Merged
jeddy3
jeddy3 approved these changes Aug 13, 2022
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think including the : character for pseudo-classes is more helpful.

I agree.

@ybiquitous ybiquitous merged commit 9afc6f3 into main Aug 14, 2022
@ybiquitous ybiquitous deleted the fix-selector-pseudo-class-allowed-list-end-positions-and-message branch August 14, 2022 06:31
@ybiquitous
Copy link
Member Author

Changelog entry added:

  • Fixed: selector-pseudo-class-allowed-list end positions and message (#6262).

This was referenced Aug 18, 2022
Closed
Open
@sync-by-unito sync-by-unito bot mentioned this pull request Sep 6, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ybiquitous @jeddy3