Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selector-no-vendor-prefix end positions #6261

Merged
merged 1 commit into from Aug 14, 2022

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Part of #5694

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

ruleNode.selector = isAutoprefixable.unprefix(ruleNode.selector);
if (!isAutoprefixable.selector(value)) {
return;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[note] Using an early return for isAutoprefixable.selector(value) reduces a nest level.

Note: Hiding whitespaces makes it easier to review the diff.

@ybiquitous ybiquitous marked this pull request as ready for review August 13, 2022 09:19
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ybiquitous ybiquitous merged commit d324493 into main Aug 14, 2022
@ybiquitous ybiquitous deleted the fix-selector-no-vendor-prefix-end-positions branch August 14, 2022 06:29
@ybiquitous
Copy link
Member Author

Changelog entry added:

  • Fixed: selector-no-vendor-prefix end positions (#6261).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants