Fix message, positions, and false positives for selector-no-qualifying-type
#6260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ybiquitous
commented
Aug 13, 2022
| @@ -78,6 +78,10 @@ const rule = (primary, secondaryOptions) => { | |||
| return; | |||
| } | |||
|
|
|||
| const ignoreId = optionsMatches(secondaryOptions, 'ignore', 'id'); | |||
| const ignoreClass = optionsMatches(secondaryOptions, 'ignore', 'class'); | |||
| const ignoreAttribute = optionsMatches(secondaryOptions, 'ignore', 'attribute'); | |||
There was a problem hiding this comment.
[note] Avoid repeated evaluations in the loop.
ybiquitous
changed the title
selector-no-qualifying-typeselector-no-qualifying-type
ybiquitous
commented
Aug 13, 2022
| &.bar {} | ||
| } | ||
| }`, | ||
| }, |
There was a problem hiding this comment.
[note] A test case for #5020.
jeddy3
approved these changes
Aug 13, 2022
ybiquitous
deleted the
fix-message-positions-for-selector-no-qualifying-type
branch
|
Thanks for your many reviews! 😊 Changelog entry added:
|
This was referenced Aug 18, 2022
Closed
ChrisBAshton
added a commit
to alphagov/support
that referenced
this pull request
Aug 24, 2022
As of stylelint v14.11.0, the `stylelint-disable-line` override no longer appears to work in this case, giving a build failure of ``` 61:3 Unexpected qualifying type selector "a.ui-state-default" selector-no-qualifying-type ``` I suspect this is down to this change: stylelint/stylelint#6260 Applying the ignore to the block of CSS rather than to the line seems to appease the linter.
ChrisBAshton
added a commit
to alphagov/support
that referenced
this pull request
Aug 24, 2022
As of stylelint v14.11.0, the `stylelint-disable-line` override no longer appears to work in this case, giving a build failure of ``` 61:3 Unexpected qualifying type selector "a.ui-state-default" selector-no-qualifying-type ``` I suspect this is down to this change: stylelint/stylelint#6260 Applying the ignore to the block of CSS rather than to the line seems to appease the linter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4410
Closes #5020
Part of #5694
This PR aims to fix three problems:
Unexpected qualifying type selector "a#id"