From 029736b90903b93f551612badd6f5c51886f9c24 Mon Sep 17 00:00:00 2001 From: Matt Wang Date: Fri, 29 Apr 2022 11:23:23 -0700 Subject: [PATCH 1/3] Fix end positions for `selector-pseudo-class-no-unknown` --- .../__tests__/index.js | 28 +++++++++++++++++++ .../selector-pseudo-class-no-unknown/index.js | 1 + 2 files changed, 29 insertions(+) diff --git a/lib/rules/selector-pseudo-class-no-unknown/__tests__/index.js b/lib/rules/selector-pseudo-class-no-unknown/__tests__/index.js index 99f4aedd1e..483a5c19a6 100644 --- a/lib/rules/selector-pseudo-class-no-unknown/__tests__/index.js +++ b/lib/rules/selector-pseudo-class-no-unknown/__tests__/index.js @@ -124,72 +124,96 @@ testRule({ message: messages.rejected(':unknown'), line: 1, column: 2, + endLine: 1, + endColumn: 10, }, { code: 'a:Unknown { }', message: messages.rejected(':Unknown'), line: 1, column: 2, + endLine: 1, + endColumn: 10, }, { code: 'a:uNkNoWn { }', message: messages.rejected(':uNkNoWn'), line: 1, column: 2, + endLine: 1, + endColumn: 10, }, { code: 'a:UNKNOWN { }', message: messages.rejected(':UNKNOWN'), line: 1, column: 2, + endLine: 1, + endColumn: 10, }, { code: 'a:pseudo-class { }', message: messages.rejected(':pseudo-class'), line: 1, column: 2, + endLine: 1, + endColumn: 15, }, { code: 'body:not(div):noot(span) {}', message: messages.rejected(':noot'), line: 1, column: 14, + endLine: 1, + endColumn: 19, }, { code: 'a:unknown::before { }', message: messages.rejected(':unknown'), line: 1, column: 2, + endLine: 1, + endColumn: 10, }, { code: 'a,\nb > .foo:error { }', message: messages.rejected(':error'), line: 2, column: 9, + endLine: 2, + endColumn: 15, }, { code: '::-webkit-scrollbar-button:horizontal:unknown {}', message: messages.rejected(':unknown'), line: 1, column: 38, + endLine: 1, + endColumn: 46, }, { code: ':first { }', message: messages.rejected(':first'), line: 1, column: 1, + endLine: 1, + endColumn: 7, }, { code: '@page :blank:unknown { }', message: messages.rejected(':unknown'), line: 1, column: 13, + endLine: 1, + endColumn: 21, }, { code: '@page foo:unknown { }', message: messages.rejected(':unknown'), line: 1, column: 10, + endLine: 1, + endColumn: 18, }, { code: ':horizontal:decrement {}', @@ -198,11 +222,15 @@ testRule({ message: messages.rejected(':horizontal'), line: 1, column: 1, + endLine: 1, + endColumn: 12, }, { message: messages.rejected(':decrement'), line: 1, column: 12, + endLine: 1, + endColumn: 22, }, ], }, diff --git a/lib/rules/selector-pseudo-class-no-unknown/index.js b/lib/rules/selector-pseudo-class-no-unknown/index.js index 8e06850c7b..b1384f508a 100644 --- a/lib/rules/selector-pseudo-class-no-unknown/index.js +++ b/lib/rules/selector-pseudo-class-no-unknown/index.js @@ -121,6 +121,7 @@ const rule = (primary, secondaryOptions) => { index, ruleName, result, + word: value, }); }); }); From 0ea77049663599da5710073071ec3ebc8feba005 Mon Sep 17 00:00:00 2001 From: Matt Wang Date: Fri, 29 Apr 2022 11:25:20 -0700 Subject: [PATCH 2/3] Fix end positions for `selector-pseudo-element-no-unknown` --- .../__tests__/index.js | 14 ++++++++++++++ .../selector-pseudo-element-no-unknown/index.js | 1 + 2 files changed, 15 insertions(+) diff --git a/lib/rules/selector-pseudo-element-no-unknown/__tests__/index.js b/lib/rules/selector-pseudo-element-no-unknown/__tests__/index.js index 296244b1c5..60db5af8d3 100644 --- a/lib/rules/selector-pseudo-element-no-unknown/__tests__/index.js +++ b/lib/rules/selector-pseudo-element-no-unknown/__tests__/index.js @@ -115,42 +115,56 @@ testRule({ message: messages.rejected('::pseudo'), line: 1, column: 2, + endLine: 1, + endColumn: 10, }, { code: 'a::Pseudo { }', message: messages.rejected('::Pseudo'), line: 1, column: 2, + endLine: 1, + endColumn: 10, }, { code: 'a::pSeUdO { }', message: messages.rejected('::pSeUdO'), line: 1, column: 2, + endLine: 1, + endColumn: 10, }, { code: 'a::PSEUDO { }', message: messages.rejected('::PSEUDO'), line: 1, column: 2, + endLine: 1, + endColumn: 10, }, { code: 'a::element { }', message: messages.rejected('::element'), line: 1, column: 2, + endLine: 1, + endColumn: 11, }, { code: 'a:hover::element { }', message: messages.rejected('::element'), line: 1, column: 8, + endLine: 1, + endColumn: 17, }, { code: 'a,\nb > .foo::error { }', message: messages.rejected('::error'), line: 2, column: 9, + endLine: 2, + endColumn: 16, }, ], }); diff --git a/lib/rules/selector-pseudo-element-no-unknown/index.js b/lib/rules/selector-pseudo-element-no-unknown/index.js index 4c2e32c084..a9bfb459f3 100644 --- a/lib/rules/selector-pseudo-element-no-unknown/index.js +++ b/lib/rules/selector-pseudo-element-no-unknown/index.js @@ -83,6 +83,7 @@ const rule = (primary, secondaryOptions) => { index: pseudoNode.sourceIndex, ruleName, result, + word: value, }); }); }); From f2eb0ce45373d070446fdadaf4a2e21f4efec911 Mon Sep 17 00:00:00 2001 From: Matt Wang Date: Fri, 29 Apr 2022 11:27:28 -0700 Subject: [PATCH 3/3] Fix end positions for `selector-type-no-unknown` --- .../__tests__/index.js | 22 +++++++++++++++++++ lib/rules/selector-type-no-unknown/index.js | 1 + 2 files changed, 23 insertions(+) diff --git a/lib/rules/selector-type-no-unknown/__tests__/index.js b/lib/rules/selector-type-no-unknown/__tests__/index.js index 7379cf38ae..ffc043e5b2 100644 --- a/lib/rules/selector-type-no-unknown/__tests__/index.js +++ b/lib/rules/selector-type-no-unknown/__tests__/index.js @@ -143,48 +143,64 @@ testRule({ message: messages.rejected('unknown'), line: 1, column: 1, + endLine: 1, + endColumn: 8, }, { code: 'uNkNoWn {}', message: messages.rejected('uNkNoWn'), line: 1, column: 1, + endLine: 1, + endColumn: 8, }, { code: 'UNKNOWN {}', message: messages.rejected('UNKNOWN'), line: 1, column: 1, + endLine: 1, + endColumn: 8, }, { code: 'ul unknown {}', message: messages.rejected('unknown'), line: 1, column: 4, + endLine: 1, + endColumn: 11, }, { code: 'unknown[target] {}', message: messages.rejected('unknown'), line: 1, column: 1, + endLine: 1, + endColumn: 8, }, { code: 'unknown:nth-child(even) {}', message: messages.rejected('unknown'), line: 1, column: 1, + endLine: 1, + endColumn: 8, }, { code: '@media only screen and (min-width: 35em) { unknown {} }', message: messages.rejected('unknown'), line: 1, column: 44, + endLine: 1, + endColumn: 51, }, { code: 'input:not(unknown) {}', message: messages.rejected('unknown'), line: 1, column: 11, + endLine: 1, + endColumn: 18, }, { code: 'x-Foo {}', @@ -192,6 +208,8 @@ testRule({ message: messages.rejected('x-Foo'), line: 1, column: 1, + endLine: 1, + endColumn: 6, }, { code: 'X-foo {}', @@ -199,6 +217,8 @@ testRule({ message: messages.rejected('X-foo'), line: 1, column: 1, + endLine: 1, + endColumn: 6, }, { code: 'X-FOO {}', @@ -206,6 +226,8 @@ testRule({ message: messages.rejected('X-FOO'), line: 1, column: 1, + endLine: 1, + endColumn: 6, }, ], }); diff --git a/lib/rules/selector-type-no-unknown/index.js b/lib/rules/selector-type-no-unknown/index.js index 441211af74..817963b5d2 100644 --- a/lib/rules/selector-type-no-unknown/index.js +++ b/lib/rules/selector-type-no-unknown/index.js @@ -105,6 +105,7 @@ const rule = (primary, secondaryOptions) => { index: tagNode.sourceIndex, ruleName, result, + word: tagName, }); }); });