Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives for arealess templates in named-grid-areas-no-invalid #6042

Merged
merged 1 commit into from Apr 28, 2022
Merged

Fix false positives for arealess templates in named-grid-areas-no-invalid #6042

merged 1 commit into from Apr 28, 2022

Conversation

jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Apr 27, 2022 •
edited

Which issue, if any, is this issue related to?

Closes #6041

Is there anything in the PR that needs further explanation?

A quick fix to avoid further checks on areas if there aren't any.

ybiquitous
ybiquitous approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeddy3 Thank you. LGTM 👍🏼

@ybiquitous ybiquitous mentioned this pull request Apr 28, 2022
Closed
@ybiquitous ybiquitous merged commit ebd556f into main Apr 28, 2022
@ybiquitous ybiquitous deleted the issue-6041 branch April 28, 2022 11:17
@ybiquitous
Copy link
Member

Changelog entry added:

Fixed: named-grid-areas-no-invalid false positives for arealess templates (#6042).

@sync-by-unito sync-by-unito bot mentioned this pull request May 1, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 1, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Jul 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix false positives regression in named-grid-areas-no-invalid
2 participants
@jeddy3 @ybiquitous