Fix end positions for function-no-unknown
#6038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ybiquitous
approved these changes
Apr 25, 2022
There was a problem hiding this comment.
@mattxwang Thank you. LGTM 👍🏼
How many should I be doing per PR?
I think it's also good to change some rules with one PR if the diff is not too huge.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the umbrella issue #5694.
Let me know if
nameshould be called something else.On a related note, I'm happy to do many of the end positions PRs (they're low-hanging fruit, and a good way for me to get more familiar with rules). How many should I be doing per PR?