Fix end positions for at-rule-*-list
#6032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ybiquitous
reviewed
Apr 23, 2022
There was a problem hiding this comment.
@mattxwang Thanks, LGTM 👍🏼
IMO, it's easier to understand if each rule message includes @, e.g.
- Unexpected at-rule "foo"
+ Unexpected at-rule "@foo"
uses `name` instead of `atRule.name` Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
ybiquitous
reviewed
Apr 24, 2022
| @@ -47,6 +47,7 @@ const rule = (primary) => { | |||
| node: atRule, | |||
| result, | |||
| ruleName, | |||
| word: `@${atRule.name}`, | |||
There was a problem hiding this comment.
Ah, this also can be simplified: 😅
Suggested change
| word: `@${atRule.name}`, | |
| word: `@${name}`, |
ybiquitous
approved these changes
Apr 24, 2022
jeddy3
changed the title
at-rule-allowed-list, at-rule-disallowed-listat-rule-*-list
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the umbrella issue #5694.
I modelled my approach off of #6026 - though, I did note that for the rule in that PR (
at-rule-no-unknown), themessageincludes the@, while for the rules in this PR, themessagedoes not. I've still included the@in the word itself; let me know if I should instead be consistent with themessage.(also not sure about the add/fix terminology for the PR title, feel free to change if needed)