Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false negative about -ms-linear-gradient in function-linear-gradient-no-nonstandard-direction #6031

Merged
merged 1 commit into from Apr 22, 2022
Merged

Fix false negative about -ms-linear-gradient in function-linear-gradient-no-nonstandard-direction #6031

merged 1 commit into from Apr 22, 2022

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Apr 22, 2022 •
edited

Which issue, if any, is this issue related to?

None.

Is there anything in the PR that needs further explanation?

Thanks to @Mouvedia (4b0f57d#r71832295), I can open this pull request. Thank you.

ybiquitous referenced this pull request Apr 22, 2022
@ybiquitous
Refactor to replace style-search for functionArgumentsSearch() (#…
4b0f57d 
…5882)

Replacing `style-search` with `postcss-value-parser`.
jeddy3
jeddy3 approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ybiquitous ybiquitous merged commit 7957260 into main Apr 22, 2022
@ybiquitous ybiquitous deleted the fix-function-linear-gradient-no-nonstandard-direction branch April 22, 2022 16:28
@ybiquitous
Copy link
Member Author

Changelog entry added:

  • Fixed: function-linear-gradient-no-nonstandard-direction false negative about -ms-linear-gradient (#6031).

@Mouvedia
Copy link
Contributor

Mouvedia commented Apr 22, 2022 •
edited

Note: if it matches -webkit-linear-gradient or -ms-linear-gradient AFAIK you won't be able to use to and will have to switch to linear-gradient. It's useful nonetheless but will require to be careful if we ever add a fix.

@sync-by-unito sync-by-unito bot mentioned this pull request May 1, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 1, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Jul 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ybiquitous @Mouvedia @jeddy3