New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for vendor prefixes in property-(dis)allowed-list
#6025
Add support for vendor prefixes in property-(dis)allowed-list
#6025
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carlosjeurissen Thanks for the pull request. Can you add a test for this change, please?
property-*-list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carlosjeurissen Thank you so much for the first contribution!
In addition, can you address the following?
- Add a simple test case for the rule change.
- Fix also the
property-allowed-list
rule in the same way.if (matchesStringOrRegExp(vendor.unprefixed(prop), primary)) {
Ah, I've overlapped with @jeddy3 😅 |
@jeddy3 Do you think it's necessary to remove the
|
Addressed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. LGTM 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Changelog entry added:
|
property-*-list
property-(dis)allowed-list
Closes #5981
The parameter types for matchesStringOrRegExp had to be fixed. It didn't include Array.