Fix no-disable regression for some rules #6018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For example, the selector-class-pattern rule currently reports a range of rule node. So the report range in the following example is from line 1 to line 3. .ProseMirror { /* stylelint-disable-line selector-class-pattern */
...
}The stylelint-disable-line cannot suppress range reporting, so it has no effect in the above example. After this PR change, the suppression comment works because it only refers to the start line of the report (line 1 in the example). |
|
In other words, this PR is reverting the next change. |
ybiquitous
approved these changes
Apr 17, 2022
jeddy3
approved these changes
Apr 17, 2022
There was a problem hiding this comment.
@ota-meshi Many thanks for the quick fix!
I'll put out a release now.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6015
This PR is modified so that stylelint-disable is enabled when the start line of the report matches.