Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix column position for *-no-important rules #5957

Merged
merged 1 commit into from Mar 8, 2022
Merged

Fix column position for *-no-important rules #5957

merged 1 commit into from Mar 8, 2022

Conversation

ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Mar 8, 2022 •
edited

Which issue, if any, is this issue related to?

Extracted from #5725. This pull request should make it easier to support the column range.

Is there anything in the PR that needs further explanation?

This change fixes a column position of !important:

a { color: ping !important; }
/** Before:      ↑ */

a { color: ping !important; }
/** After:      ↑ */

Note: I cannot find how to get a position of !important from CSS code via postcss or postcss-value-parser.
So, I've written a tiny utility to do it.

@ybiquitous
Fix column position for *-no-important rules
1a3c182 
I cannot find how to get a position of `!important` from CSS code via `postcss` or `postcss-value-parser`.
So, I've written a tiny utility to do it.
@ybiquitous ybiquitous mentioned this pull request Mar 8, 2022
Merged
7 tasks
@ybiquitous ybiquitous marked this pull request as ready for review March 8, 2022 12:20
jeddy3
jeddy3 approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

LGTM, thanks!

@ybiquitous ybiquitous merged commit b4f57f1 into main Mar 8, 2022
@ybiquitous ybiquitous deleted the fix-column-position-for-no-important-rules branch March 8, 2022 22:58
@ybiquitous
Copy link
Member Author

@jeddy3 Thank you. I've update the changelog:

  • Fixed: *-no-important column position (#5957).

@sync-by-unito sync-by-unito bot mentioned this pull request May 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ybiquitous @jeddy3