Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives/negatives in selector-pseudo-class-no-unknown #5956

Merged
merged 2 commits into from Mar 9, 2022
Merged

Fix false positives/negatives in selector-pseudo-class-no-unknown #5956

merged 2 commits into from Mar 9, 2022

Conversation

Mouvedia
Copy link
Contributor

@Mouvedia Mouvedia commented Mar 8, 2022

Which issue, if any, is this issue related to?

Closes #5173

Is there anything in the PR that needs further explanation?

check the commit message for details
prompted by #5205 (comment)

@Mouvedia
add missing pseudo classes:
75450d7 
 - `user-valid`
 - `-moz-placeholder`
 - `-moz-ui-invalid`
 - `-moz-ui-valid`
 - `-ms-input-placeholder`

add missing pseudo elements:
 - `-moz-focus-outer`
 - `-moz-placeholder`
 - `-webkit-input-placeholder`

fixes stylelint#5173

https://developer.mozilla.org/en-US/docs/web/css/:user-valid
https://bugzilla.mozilla.org/show_bug.cgi?id=457801
https://bugzilla.mozilla.org/show_bug.cgi?id=737786
Mouvedia
Mouvedia commented Mar 8, 2022
View reviewed changes
lib/reference/keywordSets.js Outdated Show resolved Hide resolved
jeddy3
jeddy3 requested changes Mar 8, 2022
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Let's remove user-error too.

lib/reference/keywordSets.js Outdated Show resolved Hide resolved
@jeddy3 jeddy3 changed the title Remove :contains() (#5173), Add missing pseudo elements/classes (non exhaustive) Fix false positives/negatives in selector-pseudo-class-no-unknown Mar 8, 2022
@Mouvedia
Copy link
Contributor Author

Mouvedia commented Mar 8, 2022

Let's remove user-error too.

done

jeddy3
jeddy3 approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM.

ybiquitous
ybiquitous approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍🏼

lib/reference/keywordSets.js Show resolved Hide resolved
@jeddy3 jeddy3 merged commit 60dd0c3 into stylelint:main Mar 9, 2022
@jeddy3
Copy link
Member

jeddy3 commented Mar 9, 2022

Changelog entry added:

  • Fixed: selector-pseudo-class-no-unknown false positives and negatives (#5956).

@Mouvedia Mouvedia mentioned this pull request Mar 11, 2022
Merged
@Mouvedia Mouvedia deleted the mouvedia-5173 branch March 12, 2022 01:26
@sync-by-unito sync-by-unito bot mentioned this pull request May 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix false negatives for :contains in selector-pseudo-class-no-unknown
3 participants
@Mouvedia @jeddy3 @ybiquitous