Fix column position for font-family-name-quotes rule
#5955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a column position of a `font-family-name-quotes` problem to include quotes.
```css
a { font-family: "Arial"; }
/* Before: ↑ */
a { font-family: "Arial"; }
/* After: ↑ */
```
ybiquitous
commented
Mar 8, 2022
| @@ -400,36 +436,26 @@ testRule({ | |||
| code: 'a { font-family: "Lucida Grande", "Arial", "sans-serif"; }', | |||
| fixed: 'a { font-family: "Lucida Grande", "Arial", sans-serif; }', | |||
| message: messages.rejected('sans-serif'), | |||
| line: 1, | |||
| column: 45, | |||
There was a problem hiding this comment.
[note] I've removed checking a position from fix: true test cases since they are duplicated with the non-fix test cases above. No problems?
ybiquitous
commented
Mar 8, 2022
| @@ -83,11 +85,16 @@ const makeMutableFontFamilies = (fontFamilies, decl) => { | |||
| const mutableNodes = []; | |||
|
|
|||
| fontFamilies.forEach((fontFamily, idx) => { | |||
| const quote = 'quote' in fontFamily && fontFamily.quote; | |||
There was a problem hiding this comment.
[note] The StringNode#quote property holds an actual quote like " or '.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #5725. This change should make it easier to support a column range.
This change fixes a column position of a
font-family-name-quotesproblem to include quotes.