Fix showing of incorrect missing package in customSyntax require handling #5763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlaub3
changed the title
ybiquitous
reviewed
Dec 6, 2021
There was a problem hiding this comment.
@dlaub3 Thank you for creating this PR! I've suggested one idea for the usage of console.error().
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
dlaub3
commented
Dec 6, 2021
remove console.error in favor of embedding the original error
|
@dlaub3 looks like it fails the CI Lint, do you want to try running |
This is the downside to applying changes via the GitHub UI. It should be good now. |
mattxwang
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
I'll defer back to @ybiquitous for a final review if needed, but on my end this LGTM! Thanks for the contribution 😄
ybiquitous
approved these changes
Dec 8, 2021
ybiquitous
added a commit
that referenced
this pull request
Dec 8, 2021
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5761
I'm not sure if the added
console.erroris beneficial. What are your thoughts?