Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resolveConfig to Node.js API #5734

Merged
merged 7 commits into from Nov 26, 2021
Merged

Add resolveConfig to Node.js API #5734

merged 7 commits into from Nov 26, 2021

Conversation

adalinesimonian
Copy link
Member

Closes #5723

Allows resolving the effective configuration for a given file, similar to --print-config on the CLI.

Allows resolving the effective configuration for a given file, similar
to --print-config on the CLI.
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adalinesimonian Great work! 👏🏼

I've suggested somes small refactoring ideas, but this PR mostly looks good to me. 👍🏼

lib/resolveConfig.js Outdated Show resolved Hide resolved
lib/resolveConfig.js Outdated Show resolved Hide resolved
types/stylelint/index.d.ts Outdated Show resolved Hide resolved
types/stylelint/index.d.ts Outdated Show resolved Hide resolved
lib/__tests__/resolveConfig.test.js Outdated Show resolved Hide resolved
lib/__tests__/resolveConfig.test.js Show resolved Hide resolved
@adalinesimonian
Copy link
Member Author

@ybiquitous Resolved comments in dfca589, af61233, and 8d664ef.

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found some typos, but LGTM! 👍🏼

types/stylelint/index.d.ts Outdated Show resolved Hide resolved
lib/__tests__/resolveConfig.test.js Outdated Show resolved Hide resolved
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adalinesimonian Thanks for the quick fix! 😄

@jeddy3 jeddy3 changed the title feat: add resolveConfig to API Add resolveConfig to Node.js API Nov 26, 2021
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jeddy3 jeddy3 merged commit 981ac5c into main Nov 26, 2021
@jeddy3 jeddy3 deleted the api-resolve-config branch November 26, 2021 16:39
@jeddy3
Copy link
Member

jeddy3 commented Nov 26, 2021

  • Added: resolveConfig to Node.js API (#5734).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add --print-config equivalent to Node.js API
3 participants