Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cwd option #5721

Merged
merged 3 commits into from Nov 21, 2021
Merged

Add cwd option #5721

merged 3 commits into from Nov 21, 2021

Conversation

adalinesimonian
Copy link
Member

Resolves #5720

  • Adds cwd to LinterOptions to allow specifying the working directory from which Stylelint should search for files
  • Adds cwd to LinterResult to allow formatters to format results using the same working directory used in the lint run

@adalinesimonian
feat: Add cwd option
63af8d7 
Resolves #5720

- Adds `cwd` to `LinterOptions` to allow specifying the working
directory from which Stylelint should search for files
- Adds `cwd` to `LinterResult` to allow formatters to format results
using the same working directory used in the lint run
@adalinesimonian adalinesimonian added the type: enhancement a new feature that isn't related to rules label Nov 16, 2021
@adalinesimonian adalinesimonian self-assigned this Nov 16, 2021
@mattxwang
Copy link
Member

I'm curious, why does this drop coveralls coverage to zero? Is it just a CI problem, or something from this feature itself (the latter seems unlikely?).

@adalinesimonian
Copy link
Member Author

I'm curious, why does this drop coveralls coverage to zero? Is it just a CI problem, or something from this feature itself (the latter seems unlikely?).

Genuinely no clue. Coverage was getting reported just fine by Jest.

ybiquitous
ybiquitous reviewed Nov 18, 2021
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adalinesimonian Thank you for creating PR!

I locally checked lcov.info content, but there are no problems. Strange. 🤔

lib/augmentConfig.js Outdated Show resolved Hide resolved
@adalinesimonian
Copy link
Member Author

Coveralls is reporting 0% coverage again: if coverage data is getting reported by Jest correctly, should we open an issue with Coveralls?

@mattxwang
Copy link
Member

Coveralls is reporting 0% coverage again: if coverage data is getting reported by Jest correctly, should we open an issue with Coveralls?

I wonder if it has to do with the master->main branch shift; I'm not super familiar with coveralls in general, but I noticed that the default branch is still master? The job is hitting NaN lines, so clearly something's going wrong 😢

ybiquitous
ybiquitous approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested a small refactoring, but LGTM! 👍🏼

lib/augmentConfig.js Outdated Show resolved Hide resolved
@jeddy3 jeddy3 changed the title feat: Add cwd option Add cwd option Nov 21, 2021
jeddy3
jeddy3 approved these changes Nov 21, 2021
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jeddy3 jeddy3 merged commit 2015d0d into main Nov 21, 2021
@jeddy3 jeddy3 deleted the cwd branch November 21, 2021 09:25
@jeddy3
Copy link
Member

jeddy3 commented Nov 21, 2021

Changelog entry added:

  • Added: cwd option (#5721).

@sync-by-unito sync-by-unito bot mentioned this pull request Jan 1, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Jan 27, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees

@adalinesimonian adalinesimonian

Labels
type: enhancement a new feature that isn't related to rules
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add cwd option to API
4 participants
@adalinesimonian @mattxwang @jeddy3 @ybiquitous