Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives for SVG type selectors in selector-type-case (#5712) #5717

Merged
merged 2 commits into from Nov 14, 2021

Conversation

hverlin
Copy link
Contributor

@hverlin hverlin commented Nov 14, 2021

SVG elements with mixed case (e.g. "foreignObject") should be ignored by the "selector-type-case" rule.

Which issue, if any, is this issue related to?

Closes #5712

Is there anything in the PR that needs further explanation?

Added .idea to .gitignore. Let me know if a separate PR should be done for this.

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hverlin Thank you! LGTM 👍🏼

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hverlin Thanks for the pull request. LGTM.

You can use a global gitignore for your editor settings.

@jeddy3 jeddy3 merged commit b37ab72 into stylelint:main Nov 14, 2021
@jeddy3
Copy link
Member

jeddy3 commented Nov 14, 2021

  • Fixed: selector-type-case false positives for SVG type selectors (#5717).

@hverlin
Copy link
Contributor Author

hverlin commented Nov 14, 2021

@jeddy3 I know but some projects might share files in the .idea or .vscode directories, so I cannot do this. This is very useful in some cases. (https://intellij-support.jetbrains.com/hc/en-us/articles/206544839-How-to-manage-projects-under-Version-Control-Systems)

@jeddy3
Copy link
Member

jeddy3 commented Nov 15, 2021

I see. No obvious right answer. You're welcome to open an issue for discussion.

@Mouvedia
Copy link
Contributor

Mouvedia commented Dec 12, 2021

@hverlin @jeddy3
It seems like you forgot 5 elements:

  • altGlyph
  • altGlyphDef
  • altGlyphItem
  • animateColor
  • glyphRef

see https://developer.mozilla.org/en-US/docs/Web/SVG/Element#obsolete_and_deprecated_elements
It matters when you maintain old codebases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix false positives for SVG type selectors in selector-type-case
4 participants