New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix false positives for maps in property-no-unknown #5690
Conversation
Was going to split into separate PRs but then ended up pushing in the same branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@strigefleur Thank you for creating this PR! 😄
I've suggested some refactoring ideas, but almost LGTM. 👍🏼
Agreed on every point :) |
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@strigefleur Thank you. LGTM! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request.
I've requested some changes.
{ | ||
code: 'a { color: #colors[somecolor]; }', | ||
description: 'Less map usage', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move this into its own testRule
case (towards the bottom of the file), which sets the custom syntax to postcss-less
as testRule
without syntax should only include vanilla CSS constructs.
testRule({
ruleName,
config: [true],
customSyntax: 'postcss-less',
accept: [
{
code: 'a { color: #colors[somecolor]; }',
description: 'Less map usage',
},
],
});
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Sure, as soon as I have at least some time.
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
(I move the test case myself).
|
Partial fix #5654
No, it's self-explanatory.