New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rule-selector-property-disallowed-list #5679
Add rule-selector-property-disallowed-list #5679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@doing-art Thanks for creating a new pull request
my previous PR #5489, targeted to that branch, has been closed
Yep, it was automatically closed by GitHub when v14
was merged.
I've requested one last changes, otherwise LGTM.
@doing-art Thanks for recreating the PR! The current HEAD revision seems a bit old because the project version specifies https://github.com/doing-art/stylelint/blob/0fcb254923ee48e14df7efc51fe997c599d1cc74/package.json#L3 The latest version is Line 3 in 85cc19c
Just in case, could you rebase the |
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
…ex.js Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
993570d
to
584c8c7
Compare
Thank you for your comment. I rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@doing-art Thank you. LGTM 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Changelog entry added:
|
@jeddy3 can we reuse rules internally?
If that's possible then we could have a new |
See this plugin - which was removed from core a while back. |
@jeddy3 that's not what I am talking about. |
The new rule rule-selector-property-disallowed-list that is mentioned in #5433 has been added.
@jeddy3 I see that the branch
v14
has been merged and my previous PR #5489, targeted to that branch, has been closed. So, I am creating this one to themain
branch.I made the change that you asked me to do in comments to the previous PR. Namely, added a new test which checks multiple errors in one CSS block.
Closes #5433