Fix false positives for hex colours in color-function-notation #5650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeddy3
requested changes
Oct 25, 2021
ybiquitous
reviewed
Oct 26, 2021
There was a problem hiding this comment.
@lachieh Thanks for creating a nice PR! I've left trivial comments, but otherwise LGTM. 👍🏼
jeddy3
requested changes
Oct 27, 2021
jeddy3
approved these changes
Oct 27, 2021
There was a problem hiding this comment.
Thank you, LGTM.
Will wait on @ybiquitous approval of those latest changes before merging.
|
kamechb
reviewed
Dec 16, 2021
|
|
||
| // scss rgba() function can accept a hex as the first param | ||
| for (const fnNode of node.nodes) { | ||
| if (fnNode.type === 'word' && fnNode.value.startsWith('#')) return false; |
There was a problem hiding this comment.
I use a color variable like $black in the function, do we handle that case? In that case, it still reports an error which is not expected.
There was a problem hiding this comment.
That issue is labelled as ready to implement. Please consider contributing if you have time.
There are steps on how to fix a bug in a rule in the Developer guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5638
isStandardSyntaxColorFunctionutil and testscolor-function-notationrule to use above function