Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ignorePseudoClasses: [] to max-nesting-depth #5620

Merged
merged 13 commits into from Oct 27, 2021
Merged

Add ignorePseudoClasses: [] to max-nesting-depth #5620

merged 13 commits into from Oct 27, 2021

Conversation

lachieh
Copy link
Contributor

@lachieh lachieh commented Oct 21, 2021

Continuing on from #5593 after major version change.

Closes #5310

@lachieh lachieh changed the title Bugfix 5310 Add ignorePseudoClasses: [] to max-nesting-depth Oct 21, 2021
@lachieh
Copy link
Contributor Author

lachieh commented Oct 25, 2021

@ybiquitous if you're in the mood to do more reviews, this one is also ready to go 😄

ybiquitous
ybiquitous reviewed Oct 26, 2021
View reviewed changes
lib/rules/max-nesting-depth/README.md Outdated Show resolved Hide resolved
lib/rules/max-nesting-depth/README.md Outdated Show resolved Hide resolved
lib/rules/max-nesting-depth/README.md Outdated Show resolved Hide resolved
lib/rules/max-nesting-depth/__tests__/index.js Outdated Show resolved Hide resolved
@lachieh
Copy link
Contributor Author

lachieh commented Oct 27, 2021

Thanks, updated all variations of pseudo-classes and changed to a and b elements instead of classes in tests and docs

ybiquitous
ybiquitous approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you! 😄

jeddy3
jeddy3 requested changes Oct 27, 2021
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looking great.

I've requested 3 minor changes to align with #5523

@ybiquitous Many thanks for doing the first-run-through review here and elsewhere. It's the heavy lifting.

lib/rules/max-nesting-depth/__tests__/index.js Outdated Show resolved Hide resolved
lib/rules/max-nesting-depth/__tests__/index.js Outdated Show resolved Hide resolved
lib/rules/max-nesting-depth/__tests__/index.js Outdated Show resolved Hide resolved
@lachieh @jeddy3
Apply suggestions from code review
c2c7813 
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
jeddy3
jeddy3 approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jeddy3 jeddy3 merged commit 4f8eea4 into stylelint:main Oct 27, 2021
@jeddy3
Copy link
Member

jeddy3 commented Oct 27, 2021

  • Added: ignorePseudoClasses: [] to max-nesting-depth (#5620).

@lachieh lachieh deleted the bugfix-5310 branch October 27, 2021 19:41
@sync-by-unito sync-by-unito bot mentioned this pull request Dec 1, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Jan 1, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Jan 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ignorePseudoClasses: [] to max-nesting-depth
3 participants
@lachieh @jeddy3 @ybiquitous