New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ignore: ["consecutive-duplicates-with-same-prefixless-values"]
to declaration-block-no-duplicate-properties
#5609
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MightyCreak Thanks for the pull request. It's looking good so far.
I've requested a change.
This option has the scope to be much broader, e.g. the following should be allowed:
a {
background: -webkit-linear-gradient(red, blue), -webkit-linear-gradient(black, white);
background: linear-gradient(red, blue), linear-gradient(black, white);
}
But this will be more involved and will require using the value parser. As such, I think we're okay to introduce the option in its current form and this more complex use case can be addressed later down the line only if there's a real-world need for it.
consecutive-duplicates-with-same-prefixless-values
ignore optionignore: ["consecutive-duplicates-with-same-prefixless-values"]
to declaration-block-no-duplicate-properties
@jeddy3 It is indeed a bit more complex to test 馃槄 |
@jeddy3 I think my PR is ready to be reviewed ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
I've requested a change to the problem messages.
I could look into it once this PR is merged
Thanks, but let's wait until someone requests the feature before we add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM 馃憤馃徏
I've left a trivial suggestion but I think this is ready to merge!
Add ignore option `consecutive-duplicates-with-same-prefixless-values` to rule `consecutive-duplicates-with-same-prefixless-values`. Fixes #5607
Changelog entry added:
|
Add ignore option
consecutive-duplicates-with-same-prefixless-values
to rule
consecutive-duplicates-with-same-prefixless-values
.Closes #5607
No, it's pretty self-explanatory I think, but it's the first time I contribute to stylelint and to any JS project, so bare with me please 馃槈