Add overrides option to config (#3128)
#5521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeddy3
requested changes
Sep 12, 2021
There was a problem hiding this comment.
@hudochenkov This is amazing, thank you!
The code and tests look good to me.
I've suggested some minor tweaks to the documentation and error message wording.
Many thanks again! This is an exciting addition that gets us closer to 14.0.0.
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
ybiquitous
reviewed
Sep 13, 2021
There was a problem hiding this comment.
@hudochenkov Thanks, this is awesome work! 😄
I've left some comments, but I think this PR is mostly fine!
ybiquitous
approved these changes
Sep 13, 2021
|
|
I'll create an issue so that we can discuss what can we do about this. |
This was referenced Sep 13, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3128.
It took quite some time to figure out how config resolutions works. Codebase is very tangled in my opinion :(
For every linted file we produce new config from initial config. All overrides are resolved and applied on a config and file gets normal config with no
overridesproperty.I took
overridesdocs from ESLint documentation with some modifications.Interesting thing that all properties that regular config support, are supported by overrides. So when we #5142 is done, all options would be working automatically for
overrides.