From d93de0099254f6ff95af6049c9b66aaf492ba92a Mon Sep 17 00:00:00 2001 From: Sylwia Laskowska Date: Sun, 5 Sep 2021 22:49:28 +0200 Subject: [PATCH] Refactor atrule statement in unit-no-unknown --- lib/rules/unit-no-unknown/__tests__/index.js | 9 --------- lib/rules/unit-no-unknown/index.js | 5 +++-- 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/lib/rules/unit-no-unknown/__tests__/index.js b/lib/rules/unit-no-unknown/__tests__/index.js index 697a65d4af..a09be6a1a4 100644 --- a/lib/rules/unit-no-unknown/__tests__/index.js +++ b/lib/rules/unit-no-unknown/__tests__/index.js @@ -480,15 +480,6 @@ testRule({ description: 'ignore variable names', }, ], - - reject: [ - { - code: '@variable: 10pix', - message: messages.rejected('pix'), - line: 1, - column: 12, - }, - ], }); testRule({ diff --git a/lib/rules/unit-no-unknown/index.js b/lib/rules/unit-no-unknown/index.js index 9c0f44fe71..7ca34f10a4 100644 --- a/lib/rules/unit-no-unknown/index.js +++ b/lib/rules/unit-no-unknown/index.js @@ -5,6 +5,7 @@ const atRuleParamIndex = require('../../utils/atRuleParamIndex'); const declarationValueIndex = require('../../utils/declarationValueIndex'); const getUnitFromValueNode = require('../../utils/getUnitFromValueNode'); +const isStandardSyntaxAtRule = require('../../utils/isStandardSyntaxAtRule'); const isStandardSyntaxDeclaration = require('../../utils/isStandardSyntaxDeclaration'); const keywordSets = require('../../reference/keywordSets'); const mediaParser = require('postcss-media-query-parser').default; @@ -128,8 +129,8 @@ function rule(actual, options) { }); } - root.walkAtRules((atRule) => { - if (!/^media$/i.test(atRule.name) && !atRule.variable) { + root.walkAtRules(/^media$/i, (atRule) => { + if (!isStandardSyntaxAtRule(atRule)) { return; }