Fix false positives for Less maps in property-no-unknown #5381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeddy3
changed the title
jeddy3
requested changes
Jul 13, 2021
There was a problem hiding this comment.
@jrlmontejo Thanks for the pull request, and apologies for just getting around to reviewing it.
Can you please:
- set to merge into the
v14branch - add a test to
isStandardSyntaxDeclaration.test.js
I think we'll be good then.
ghost
changed the base branch from
|
@jeddy3 I applied the requested changes. Thanks! |
jeddy3
approved these changes
Jul 15, 2021
ybiquitous
requested changes
Jul 16, 2021
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
|
v14 changelog entry:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4834
None