Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Node 10 support for ESM #5303

Merged
merged 1 commit into from May 14, 2021
Merged

Drop Node 10 support for ESM #5303

merged 1 commit into from May 14, 2021

Conversation

ybiquitous
Copy link
Member

This change is a part of the next major version (v14).

  • Remove Node 10 from CI
  • Update engines.node

In addition, this removes needless CI: true (just a refactoring).
See https://github.blog/changelog/2020-04-15-github-actions-sets-the-ci-environment-variable-to-true/

Which issue, if any, is this issue related to?

Closes #5292

Is there anything in the PR that needs further explanation?

See also:

@ybiquitous
Drop Node 10 support for ESM
425ce02 
This change is a part of the next major version (v14).

- Remove Node 10 from CI
- Update `engines.node`

In addition, this removes needless `CI: true` (just a refactoring).
See <https://github.blog/changelog/2020-04-15-github-actions-sets-the-ci-environment-variable-to-true/>
@ybiquitous ybiquitous marked this pull request as ready for review May 14, 2021 09:44
jeddy3
jeddy3 approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Some of the CI checks didn't start for some reason. I've restarted the tests for this and the other pull requests.

@jeddy3
Copy link
Member

jeddy3 commented May 14, 2021

It looks like the mac-os runners are down. I think we're good to merge regardless.

@ybiquitous ybiquitous merged commit 37e1190 into v14 May 14, 2021
@ybiquitous ybiquitous deleted the issue-5292 branch May 14, 2021 11:01
@ybiquitous
Copy link
Member Author

Thanks for the review! 😄

@ybiquitous ybiquitous mentioned this pull request May 14, 2021
Closed
@ybiquitous
Copy link
Member Author

v4 changelog:

Removed: Drop Node 10 support (#5303).

90a174d

@ybiquitous
Copy link
Member Author

ybiquitous commented May 14, 2021 •
edited

It might be better to describe more to the changelog. 🤔

@jeddy3
Copy link
Member

jeddy3 commented May 14, 2021

Let's keep each entry terse for now and we'll improve the changelog in one go when we do the migration guide. It'll be easier that way.

Ref: #5301

@ybiquitous
Copy link
Member Author

Make sense. 👍🏼

@sync-by-unito sync-by-unito bot mentioned this pull request Nov 1, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Dec 1, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Jan 1, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Jan 27, 2022
Closed
@ybiquitous ybiquitous mentioned this pull request Feb 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudochenkov hudochenkov hudochenkov approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ybiquitous @jeddy3 @hudochenkov