Remove function-calc-no-invalid

[jeddy3]

Which issue, if any, is this issue related to?

Closes #4731

Is there anything in the PR that needs further explanation?

Removes one of the two code scanning vulnerabilities. This one is found in the generated parser code used by the rule.

This is the 2nd pull request for the v14 branch.

Once we merged this pull request and #5295, we'll be able to tackle #5289 (removing the syntax option). Once that is done, I believe all the other 14.0.0 release issues, e.g. moving to ESM and migrating to PostCSS 8, will be unblocked and can be worked on in parallel because they shouldn't conflict with each other.

[ybiquitous]

Removes one of the two code scanning vulnerabilities. This one is found in the generated parser code used by the rule.

@jeddy3 Can we remove lib/utils/parseCalcExpression also via this PR? It seems to be used only by function-calc-no-invalid.

[ybiquitous]

One more question: should we announce the deprecation of function-calc-no-invalid before releasing v14.0.0?
That is, should we release some 13.x version marking this rule as deprecated?

[jeddy3]

One more question: should we announce the deprecation of function-calc-no-invalid before releasing v14.0.0?

I wasn't going to bother with a deprecation cycle. It's needless work.

[ybiquitous]

I wasn't going to bother with a deprecation cycle. It's needless work.

Make sense. Thank you for the answer. 👍🏼

[ybiquitous]

Thanks for the commit f117326. Can we also remove the following lines?

$ git grep parseCalcExpression
.eslintignore:3:lib/utils/parseCalcExpression/parser.js
.prettierignore:13:lib/utils/parseCalcExpression/parser.js
package.json:78:      "!lib/utils/parseCalcExpression/parser.js"

[ybiquitous]

LGTM! 🙌🏼

[jeddy3]

@ybiquitous Thanks for catching all the bits I missed!

[jeddy3]

v14 changelog:

• Removed: function-calc-no-invalid (#5296).