Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives for dollar variables in no-invalid-position-at-import-rule #5264

Merged
merged 1 commit into from May 1, 2021
Merged

Fix false positives for dollar variables in no-invalid-position-at-import-rule #5264

merged 1 commit into from May 1, 2021

Conversation

jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Apr 27, 2021

Which issue, if any, is this issue related to?

Closes #5263

Is there anything in the PR that needs further explanation?

Switches the logic around so that the invalidPosition flag is set when a standard syntax rule or at-rule (that isn't charset or another import) is encountered.

It maps neatly onto the spec:

Any @import rules must precede all other valid at-rules and style rules in a style sheet (ignoring @charset), or else the @import rule is invalid.

@jeddy3 jeddy3 changed the title Fix false positives for dollar variables Fix false positives for dollar variables in no-invalid-position-at-import-rule Apr 27, 2021
ybiquitous
ybiquitous approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍🏼

@jeddy3 jeddy3 mentioned this pull request Apr 30, 2021
Closed
6 tasks
mattxwang
mattxwang approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeddy3 jeddy3 merged commit 2e90b96 into master May 1, 2021
@jeddy3 jeddy3 deleted the issue-5263 branch May 1, 2021 09:49
@jeddy3
Copy link
Member Author

jeddy3 commented May 1, 2021

  • Fixed: no-invalid-position-at-import-rule false positives for dollar variables (#5264).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

@mattxwang mattxwang mattxwang approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix false positives for dollar variables in no-invalid-position-at-import-rule
3 participants
@jeddy3 @ybiquitous @mattxwang