Add selector-disallowed-list rule #5239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doing-art
changed the title
|
Hello everyone. One check related to this PR fails. Should I fix it? Or it is an infrastructural issue and you will fix it on your own? |
|
@doing-art It was a weird issue. Tests restart helped. |
Thanks a lot for your help. I really appreciate it |
ybiquitous
reviewed
Apr 12, 2021
There was a problem hiding this comment.
@doing-art Thanks for the contribution! LGTM for the code changed. 👍
I've left some comments for the document, so please confirm them.
Added a dot symbol to the `selector-disallowed-list` rule Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Added a dot symbol to the `selector-disallowed-list` rule Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Add detailed description of the paramteres of `selector-disallowed-list` rule Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
ybiquitous
approved these changes
Apr 13, 2021
There was a problem hiding this comment.
@doing-art Thank you for addressing my suggestions!
I've left a trivial suggestion, but your change looks good to me! 😄
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
|
Changelog entry added:
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5116 .
No, it's self-explanatory.