Add ignore: ["inside-function"] to declaration-property-unit-allowed-list #5194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattxwang
changed the title
ybiquitous
reviewed
Mar 27, 2021
There was a problem hiding this comment.
@abea Thank you for the contribution! The behavior itself looks good to me. 👍
I've left some review comments for clarity and consistency, so I hope you confirm them.
lib/rules/declaration-property-unit-allowed-list/__tests__/index.js
Outdated
Show resolved
Hide resolved
|
That should be all set. Thanks for the comments, @ybiquitous |
ybiquitous
approved these changes
Apr 1, 2021
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
|
Changelog entry added:
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5140
This should help support SCSS functions as well, such as the
lightencolor function.