Fix false positives for :autofill in selector-pseudo-class-no-unknown #5171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- document :contains() before its removal - remove JSONSelect val pseudo-class (guilty commit 8c808d0)
jeddy3
changed the title
This was referenced Feb 26, 2021
Closed
|
Thank you @Mouvedia 🎉 Changelog updated with: |
@m-allanson maybe add |
This was referenced Mar 7, 2021
Merged
Merged
Closed
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5168
I consider removing
:contains()a breaking change hence it will have to wait for the next major.FYI it was dropped "due to a lack of implementations".
e.g. Selenium used Sizzle which supported
:contains().:val()was erroneously added because it was listed in one of the specification's examples.ref: https://github.com/lloyd/JSONSelect/blob/master/JSONSelect.md#language-overview