Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some false positives in *-no-unknown rules #5158

Merged
merged 1 commit into from Feb 23, 2021

Conversation

Mouvedia
Copy link
Contributor

@Mouvedia Mouvedia commented Feb 20, 2021

Which issue, if any, is this issue related to?

#5157

Is there anything in the PR that needs further explanation?

lh and rlh units are supported by Safari.
https://trac.webkit.org/changeset/259703/webkit/
caveat: https://bugs.webkit.org/show_bug.cgi?id=211351

the commit message lists @​property but GitHub displays it as @Property

- @Property
- nobr tag
- :state()
- ::file-selector-button
- lh, rlh, mozmm units
@Mouvedia Mouvedia changed the title Fix some false positives in *-no-unknown rules () Fix some false positives in *-no-unknown rules Feb 20, 2021
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Mouvedia
Copy link
Contributor Author

Mouvedia commented Feb 22, 2021

keywordSets.levelThreePseudoElements = new Set([

One remark, this variable will either have to be renamed or split.
It's dubious that making the distinction between level 3 and 4 will be useful.

Since ::spelling-error—which is level 4—was part of that list, I didn't bother.

@jeddy3 jeddy3 merged commit 4fcbfe8 into stylelint:master Feb 23, 2021
@Mouvedia Mouvedia deleted the mouvedia-no-unknown branch February 23, 2021 15:00
This was referenced Mar 7, 2021
This was referenced Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants