Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disable reporting to be controlled from the config file #5126

Merged
merged 4 commits into from Feb 6, 2021

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Feb 4, 2021

This will also make it easier to control disables on a file-by-file basis
once #3128 is implemented. It will also make it possible to add
finer-grained configuration to these rules in the future.

Closes #3858

@nex3 nex3 requested review from jathak and vankop February 4, 2021 23:20
This will also make it easier to control disables on a file-by-file
basis once #3128 is implemented. It will also make it possible to add
finer-grained configuration to these rules in the future.
lib/needlessDisables.js Outdated Show resolved Hide resolved
Co-authored-by: Jennifer Thakar <jathak@google.com>
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nex3 Thank you. It's amazing to see this go in. As you said, it's the first step towards adding the overrides configuration property (which opens up so many possibilities). It's also the first step towards being able to configure everything from within the configuration object, rather than a hodgepodge of properties, parameters and flags.

I've requested some minor documentation changes.

At the start of last year we restructured and rewrote the majority of the docs. This included removing a lot of duplication where API parameters, CLI flags and configuration properties had fallen out of sync.

I'm aware this pull request reintroduces duplication, but I suggest we roll with it for now. I'll also merge in #5005, which duplicates the CLI flags. Once everything is configurable within the configuration object, I think we'll be better positioned to revisit the documentation and find a structure that both avoids duplication and is intuitive for users.

docs/user-guide/configure.md Outdated Show resolved Hide resolved
docs/user-guide/configure.md Outdated Show resolved Hide resolved
docs/user-guide/configure.md Outdated Show resolved Hide resolved
docs/user-guide/configure.md Outdated Show resolved Hide resolved
@nex3 nex3 requested a review from jeddy3 February 5, 2021 21:26
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the requested changes.

LGTM!

@jeddy3 jeddy3 merged commit 4fc7fa8 into master Feb 6, 2021
@jeddy3 jeddy3 deleted the needless-disable-controls branch February 6, 2021 08:53
@jeddy3
Copy link
Member

jeddy3 commented Feb 6, 2021

  • Added: ignoreDisables, reportNeedlessDisables, reportInvalidScopeDisables and reportDescriptionlessDisables configuration object properties (#5126).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add support for reportNeedlessDisables to the configuration object
4 participants