Fix false positives for valueless attribute selectors in selector-attribute-name-disallowed-list #5060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeddy3
changed the title
|
Can I merge this PR myself? |
|
@vkrol I'm not sure if you have rights to edit CHANGELOG via website https://stylelint.io/maintainer-guide/pull-requests |
|
@hudochenkov thank you very much! I missed this guide :( I updated |
|
@hudochenkov could you please review the change in |
|
@vkrol I don't need to update changelog in a PR. After PR is merged we update changelog via webinterface. You might not have right to change changelog via web-interface, because it's a commit directly to Anyway, I'll merge this PR as it looks good :) |
Oh, sorry. This is not my best day ever :( Thank you for your patience! :) |
vkrol
deleted the
handle-valueless-attribute-selectors-in-selector-attribute-name-disallowed-list-rule
branch
|
Don't worry! It's alright :) |
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5059.
No, it's self-explanatory.
/cc @rletsin