Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*-notation: fix false negatives for $ vars (#5010) #5031

Merged
merged 1 commit into from Nov 17, 2020
Merged

*-notation: fix false negatives for $ vars (#5010) #5031

merged 1 commit into from Nov 17, 2020

Conversation

tao-cumplido
Copy link
Contributor

Which issue, if any, is this issue related to?

Closes #5010

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

jeddy3
jeddy3 approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

ybiquitous
ybiquitous approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@jeddy3 jeddy3 merged commit 1e6f944 into stylelint:master Nov 17, 2020
@jeddy3
Copy link
Member

jeddy3 commented Nov 17, 2020

Changelog:

  • Fixed: *-notation false negatives for dollar variables (#5031).

@tao-cumplido tao-cumplido deleted the fix/5010/false-negative-scss-notation-rules branch November 17, 2020 15:32
This was referenced Mar 8, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 15, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix false negatives for dollar variables in *-notation
3 participants
@tao-cumplido @jeddy3 @ybiquitous