Add ignoreAtRules to property-no-unknown #4965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ybiquitous
reviewed
Oct 6, 2020
ybiquitous
reviewed
Oct 7, 2020
ybiquitous
approved these changes
Oct 7, 2020
jeddy3
requested changes
Oct 11, 2020
There was a problem hiding this comment.
@Zacharias3690 Thanks for making a start on this. I've requested some changes, including a substantial one to how this option should work.
jeddy3
changed the title
|
Sorry to be a bit of a bother, but would it be possible to add |
hudochenkov
requested changes
Oct 20, 2020
hudochenkov
approved these changes
Oct 21, 2020
|
@jeddy3 is it good to go? @Zacharias3690 I've added the label :) |
jeddy3
requested changes
Nov 1, 2020
There was a problem hiding this comment.
@Zacharias3690 Thanks for making the changes.
Just a couple of minor nitpicks (made as suggestions so they're easy to commit), then I think we're good!
- whitespace after the at-rule name as more common to see it like that, even though without a space is valid and parses correctly
- using
not-...rather than underscores in names, to be consistent with the tests in other rules
(My bad for not including the space after the at-rule name in the original request).
jeddy3
approved these changes
Nov 3, 2020
m-allanson
added a commit
that referenced
this pull request
Nov 5, 2020
* master: (46 commits) Update CHANGELOG.md Add ignoreAtRules to property-no-unknown (#4965) Bump eslint from 7.11.0 to 7.12.1 (#5017) Bump typescript from 4.0.3 to 4.0.5 (#5016) Bump lint-staged from 10.4.0 to 10.5.1 (#5014) Bump remark-cli from 8.0.1 to 9.0.0 (#4996) Bump jest-circus from 26.5.3 to 26.6.1 (#5009) Bump got from 11.7.0 to 11.8.0 (#5007) Bump jest from 26.5.3 to 26.6.1 (#5008) Refactor formatter tests (#4988) Fix `isStandardSyntaxDeclaration.test.js` that use callbacks (#4972) Update CHANGELOG.md Add "comment-pattern" rule (#4962) Update CHANGELOG.md Show the pattern in "*-pattern" rule messages (#4975) Enable ESLint `no-shadow` and add disable comments (#4986) Report disables in the same manner as lints (#4973) Update dependencies (#4982) Fix some tests that use callbacks (#4970) Use own vendor utility instead of PostCSS (#4942) (#4963) ...
This was referenced Mar 8, 2021
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4928
No, it's self explanatory