Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-line disable descriptions #4895

Merged
merged 3 commits into from Aug 17, 2020
Merged

Conversation

jathak
Copy link
Contributor

@jathak jathak commented Aug 12, 2020

Which issue, if any, is this issue related to?

Fixes #4886.

Is there anything in the PR that needs further explanation?

This works around postcss/postcss-scss#109 by combining adjacent // comments into a single node before passing it to checkComment.

Copy link
Contributor

@nex3 nex3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but I'm hoping someone with more stylelint experience can also review.

lib/__tests__/disableRanges.test.js Show resolved Hide resolved
lib/assignDisabledRanges.js Show resolved Hide resolved
lib/assignDisabledRanges.js Outdated Show resolved Hide resolved
lib/assignDisabledRanges.js Outdated Show resolved Hide resolved
@jathak
Copy link
Contributor Author

jathak commented Aug 17, 2020

Am I okay to merge this or should a core team member do so?

@vankop
Copy link
Member

vankop commented Aug 17, 2020

@jathak yep, hope we will not forget to update changelog..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add support for multi-line single-line disable descriptions
3 participants