Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignoreComments[] to comment-empty-line-before #4841

Merged
merged 4 commits into from Jun 24, 2020
Merged

Add ignoreComments[] to comment-empty-line-before #4841

merged 4 commits into from Jun 24, 2020

Conversation

LKummer
Copy link
Contributor

@LKummer LKummer commented Jun 24, 2020

Which issue, if any, is this issue related to?

Closes #4814.

Is there anything in the PR that needs further explanation?

It is pretty self explanatory, I mostly followed instructions from the issue.

@LKummer LKummer changed the title Feature ignore comments Add ignoreComments[] to comment-empty-line-before Jun 24, 2020
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LKummer Thank you for your first-time contribution!

It all looks good to me, thank you.

@LKummer
Copy link
Contributor Author

LKummer commented Jun 24, 2020

@LKummer Thank you for your first-time contribution!

It all looks good to me, thank you.

Great to hear, thank you for the very quick response.

@jeddy3
Copy link
Member

jeddy3 commented Jun 24, 2020

Great to hear, thank you for the very quick response.

No worries! You timed your pull request just right as I usually dip into open-source between 12 pm and 2 pm each day.

Copy link
Member

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @LKummer 👍

@m-allanson m-allanson merged commit a8042e7 into stylelint:master Jun 24, 2020
@LKummer
Copy link
Contributor Author

LKummer commented Jun 24, 2020

Thank you for the review @m-allanson.

It was an absolute joy to contribute.

@LKummer LKummer deleted the feature-ignore-comments branch June 24, 2020 14:16
m-allanson added a commit that referenced this pull request Jul 8, 2020
# By Richard Hallows (4) and others
# Via GitHub
* master:
  Create codeql analysis workflow (#4850)
  Update CHANGELOG.md
  Add support for descriptions in stylelint command comments (#4848)
  Update CHANGELOG.md
  Add *-allowed-list/*-disallowed-list/*-required-list names for *-whitelist/*-blacklist/*-requirelist rules (#4845)
  Update CHANGELOG.md
  Add syntax object acceptance to customSyntax option (#4839)
  Bump typescript from 3.9.5 to 3.9.6 (#4853)
  Add ignoreComments[] to comment-empty-line-before (#4841)
  Bump autoprefixer from 9.8.0 to 9.8.2 (#4838)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add ignoreComments: [] to comment-empty-line-before
3 participants