New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate selectors consistently. Fixes #3130 #4483
Validate selectors consistently. Fixes #3130 #4483
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
I think we can use isStandardSyntaxSelector
in isStandardSyntaxRule
, because for standard syntax rule selector also should be in standard syntax.
This way we won't need checks like:
if (!isStandardSyntaxRule(rule) || !isStandardSyntaxSelector(rule.selector)) {
We'll keep more simple:
if (!isStandardSyntaxRule(rule)) {
…f `isStandardSyntaxRule`.
No problem, happy to help!
This makes sense and I've stripped it out of most of the places that make sense. There are a few separate calls left but from what I gathered I think they're separate selector validations around nested and surrounding selectors. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Please, as a new contributor, don't merge PRs just yet. Learn our processes, and observe. |
|
@hudochenkov Apologies, I didn't see the option to merge before, so when I saw the option existed I switched to following my usual process, (although the fact it's merging to master rather that an integration branch...) I'll refrain from merging in the future though, was just trying to save some work! :) |
No worries :) |
Closes #3130.
No, it's self explanatory.