Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow comments after commas in value lists when requiring newlines. F… #4482

Merged
merged 1 commit into from Dec 22, 2019
Merged

Allow comments after commas in value lists when requiring newlines. F… #4482

merged 1 commit into from Dec 22, 2019

Conversation

dom111
Copy link
Contributor

@dom111 dom111 commented Dec 13, 2019 •
edited

…ixes #2906.

Which issue, if any, is this issue related to?

Closes #2906

Is there anything in the PR that needs further explanation?

I used selector-list-comma-newline-after as inspiration for the approach with a couple of minor tweaks.

hudochenkov
hudochenkov approved these changes Dec 15, 2019
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for fixing this bug!

@hudochenkov hudochenkov merged commit 54c62e8 into stylelint:master Dec 22, 2019
@hudochenkov
Copy link
Member

  • Fixed: value-list-comma-newline-after false positives for shared-line comments (#4482).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudochenkov hudochenkov hudochenkov approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix false positives for shared-line comments in value-list-comma-newline-after
3 participants
@dom111 @hudochenkov @alexander-akait