Remove Flow #4451
Merged
Remove Flow #4451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanich37
approved these changes
Nov 28, 2019
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4245.
It's a breaking change, because we include
flow-typedinto npm package.I removed Flow in the first commit. And in the second I removed all Flow comments.
Just for history: How I removed Flow comments.
Initial idea was to write simple Babel plugin which will remove comments. But after hour digging into plugin development for Babel I couldn't find how to work with comments in Babel ¯\_(ツ)_/¯ Comments aren't tretead as any other AST node for some reason.
So I just used VS Code and search and replace using RegExp :) I was done in 10 minutes.
Here's RegExp I used: