Ignore x unit in some cases
#4427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
requested changes
Nov 21, 2019
| { | ||
| code: 'a { image-resolution: 1x; }', | ||
| description: 'ignore `x` unit in image-resolution', | ||
| }, |
There was a problem hiding this comment.
Let's add test with @media (resolution: 2x) and (min-width: 200x) {}, second should be rejected
There was a problem hiding this comment.
I had to update logic so that such a case could be handled properly.
Not sure about implementation though.
Any suggestions are welcome.
That's what I did in the last commit :) |
alexander-akait
requested changes
Nov 21, 2019
lib/rules/unit-no-unknown/index.js
Outdated
| if ( | ||
| node.type === 'decl' && | ||
| (node.prop.toLowerCase() === 'image-resolution' || /^image-set/i.test(node.value)) | ||
| ) { |
There was a problem hiding this comment.
I think we can parse decl here too, because you can use background: image-set("../../media/examples/star.png" 1x) left 20x / 15% 60% repeat-x
There was a problem hiding this comment.
Nice case. Updated the logic.
alexander-akait
approved these changes
Nov 22, 2019
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should close #3770 .
No, it's self explanatory.