New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update globby requirement from ^9.2.0 to ^10.0.1 #4254
Conversation
Appveyor didn't pick up this PR. Will try to close/open to trigger it. |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Updates the requirements on [globby](https://github.com/sindresorhus/globby) to permit the latest version. - [Release notes](https://github.com/sindresorhus/globby/releases) - [Commits](sindresorhus/globby@v9.2.0...v10.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
24e4fc2
to
e1442b4
Compare
Looks like fix works. Problem was related to
So we have to convert all our tests cases to forward-slashes (mostly stuff with Maybe it will be required to note this for our users as well |
I think we need create discussion about this, since my implementation is not perfect. There is no way to pass |
lib/standalone.js
Outdated
if (typeof fileList === "string") { | ||
fileList = [fileList]; | ||
} | ||
let fileList = [].concat(files).map(file => file.replace(/\\/g, "/")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can potentially output linux paths on windows, we need test this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not understand what you exactly mean =(
If you mean that stylelint
can try to output fixed code to wrong (linux-like) file path, than we have such tests, see https://github.com/stylelint/stylelint/blob/master/system-tests/fix/fix.test.js#L60
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I found only one workaround for
There is no way to pass
\
in file name
and
no ability to use backslashes for escaping characters
allow users escape with double backslashes only 🙀
Because we prepare new major release it can be breaking change like:
And only fix our tests |
you can pass it, but it will be interpreted as escaping next character I agree with your suggestion to update only tests. However, |
@vankop no, many glob implementations don't support
Maybe we should look in eslint code base and find what they do in this situation |
Problem converting |
only if they have double backslashes =) anyway solution with updating tests is better, I just pointed that it will require some changes to our users I will take a look on eslint solution, too. |
Also windows support |
Actually |
I think we can do same |
Ok 🤝 So.. to sum up ✍🏼:
|
We're going to release new major in beginning of January. @vankop do you thing you make required changes till then? |
I think we need just to resolve conflicts |
# Conflicts: # lib/__tests__/ignore.test.js
# Conflicts: # system-tests/fix/fix.test.js
@hudochenkov I think we need write a note ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
I need help with changelog entry. If understand correctly, this might be a breaking change for some users. Here's what I understand:
|
I think that's a reasonable assumption that its a breaking change for Windows users |
|
Updates the requirements on globby to permit the latest version.
Release notes
Sourced from globby's releases.
Commits
4a47044
10.0.1a226f5d
Don't throw when specifying a non-existingcwd
directory (#125)5b0834a
Readme tweaks878ef6e
10.0.03706920
Upgradefast-glob
package to v3 (#126)8aadde8
Addglobby.stream
(#113)2dd76d2
Remove**/bower_components/**
as a default ignore pattern9f781ce
Require Node.js 804d51bf
Upgradeignore
package (#120)2b61484
Readme tweaksDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot will not automatically merge this PR because it includes an out-of-range update to a production dependency.
Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.
You can always request more updates by clicking
Bump now
in your Dependabot dashboard.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and language@dependabot badge me
will comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard:
Finally, you can contact us by mentioning @dependabot.