Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated syntax options #4007

Closed
hudochenkov opened this issue Apr 3, 2019 · 2 comments
Closed

Remove deprecated syntax options #4007

hudochenkov opened this issue Apr 3, 2019 · 2 comments
Labels
type: refactor an improvement to the code structure
Milestone
future-major

Comments

@hudochenkov
Copy link
Member

Options styled, and jsx for syntax were replaced with css-in-js in #3872.

We should remove them in the next major release.

We didn't show any deprecation notice. We can't release release new patch version with deprecation notice without making a special branch for release. Because master has breaking changes already.

It's should be fine. We'll address this change in release notes.
@hudochenkov hudochenkov added the type: refactor an improvement to the code structure label Apr 3, 2019
@hudochenkov hudochenkov added this to the future-major milestone Apr 3, 2019
@jeddy3
Copy link
Member

jeddy3 commented Apr 4, 2019

We'll address this change in release notes.

SGTM. I think we can just remove the old styled and jsx options for 10.0.0.

@hudochenkov hudochenkov mentioned this issue Apr 6, 2019
Merged
@ntwb ntwb closed this as completed in #4009 Apr 8, 2019
ntwb pushed a commit that referenced this issue Apr 8, 2019
@hudochenkov @ntwb
Remove styled and jsx syntax options (#4009)
9efd6f4 
> Which issue, if any, is this issue related to?

Closes #4007

> Is there anything in the PR that needs further explanation?

No, it's self explanatory.
@ntwb
Copy link
Member

ntwb commented Apr 8, 2019

Changelog: bfbf462

Removed: styled and jsx syntax options that were replaced with css-in-js in v9.10.0 (#4007).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: refactor an improvement to the code structure
Milestone
future-major
Development

No branches or pull requests
3 participants
@hudochenkov @jeddy3 @ntwb